Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing arguments in Galactica's from_pb #1022

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

Vinno97
Copy link
Contributor

@Vinno97 Vinno97 commented Sep 14, 2023

What does this PR do?

Fixes #1004

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Narsil
Copy link
Collaborator

Narsil commented Sep 20, 2023

Thanks a lot for this.

@Narsil Narsil merged commit 123749a into huggingface:main Sep 21, 2023
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing 2 required positional arguments: 'top_n_tokens' and 'top_n_tokens_tensor' for the galactica model
2 participants