Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass on model_kwargs when exporting a SentenceTransformers model #2126

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

sjrl
Copy link
Contributor

@sjrl sjrl commented Dec 13, 2024

What does this PR do?

Fixes #2115

This passes on the model_kwargs in get_model_from_task to the SentenceTransformer's model_kwargs parameter. Additionally, we add torch_dtype to model_kwargs before doing this so we can export SentenceTransformer's models in different dtypes.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

Tagging @michaelbenayoun for a review

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @sjrl !

@echarlaix echarlaix merged commit 4daa408 into huggingface:main Dec 13, 2024
32 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass torch_dtype when exporting a Sentence Transformers model to ONNX
3 participants