Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop python 3.8 #2086

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Drop python 3.8 #2086

merged 3 commits into from
Nov 5, 2024

Conversation

echarlaix
Copy link
Collaborator

@echarlaix echarlaix commented Oct 30, 2024 •
edited
Loading

https://devguide.python.org/versions/ python 3.8 has end-of-life status since 2024-10-07

same for transformers (likely included in v4.47)

@echarlaix echarlaix marked this pull request as ready for review October 30, 2024 16:05
michaelbenayoun
michaelbenayoun approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@michaelbenayoun michaelbenayoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@echarlaix echarlaix merged commit 35eebfe into main Nov 5, 2024
38 of 39 checks passed
@echarlaix echarlaix deleted the drop-python38 branch November 5, 2024 09:01
@echarlaix
Copy link
Collaborator Author

echarlaix commented Nov 5, 2024 •
edited
Loading

also adding every subpackages maintainer to make sure this works for everyone before we do any release @regisss @IlyasMoutawwakil @dacorvo @JingyaHuang @mht-sharma @tengomucho

echarlaix added a commit that referenced this pull request Nov 5, 2024
@echarlaix
Revert "Drop python 3.8 (#2086)"
23534e3 
This reverts commit 35eebfe.
@echarlaix echarlaix mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbenayoun michaelbenayoun michaelbenayoun approved these changes

@IlyasMoutawwakil IlyasMoutawwakil Awaiting requested review from IlyasMoutawwakil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@echarlaix @michaelbenayoun