Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix is_torch_tpu_available in ORT Trainer #2028

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

regisss
Copy link
Contributor

@regisss regisss commented Sep 18, 2024

What does this PR do?

Following #2012. There is one occurrence of is_torch_tpu_available in the code of the ORTTrainer class, which will fail for transformers >= 4.39.0.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@IlyasMoutawwakil IlyasMoutawwakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the fix !

@regisss regisss merged commit 2fb5ea5 into main Sep 18, 2024
46 of 48 checks passed
@regisss regisss deleted the fix_ort_trainer_xla branch September 18, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants