Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Param Cache For Recompilation #2000

Conversation

zhenglongjiepheonix
Copy link
Contributor

The parameter cache instance is needed to handle recompilation where we need to make sure the parameters we created in the first run are used, currently the use case does not fall into error even without param cache because we directly replace layers in layer cache in recompilation(parameters are replaced automatically because layers are replaced), but there are still some parameters which is not traced within a standalone module(like layernorm weight), it still works fine for now because we directly use the original parameter instead of creating new ones for initialization and weights loading if it is already on the current rank device, however, in cases where we need to support third-party backends like nanotron which has its own implementation of NanotronParameter, we do need to track all the newly created parameters so that no new parameter is created in recompilation.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@michaelbenayoun michaelbenayoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhenglongjiepheonix zhenglongjiepheonix merged commit 23f8574 into huggingface:main Aug 29, 2024
43 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants