Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support transformers 4.42 #1929

Merged
merged 9 commits into from
Jul 1, 2024
Merged

Support transformers 4.42 #1929

merged 9 commits into from
Jul 1, 2024

Conversation

fxmarty
Copy link
Contributor

@fxmarty fxmarty commented Jun 28, 2024

No description provided.

@fxmarty
Copy link
Contributor Author

fxmarty commented Jun 28, 2024

will need to patch mistral huggingface/transformers#31696

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@fxmarty fxmarty mentioned this pull request Jul 1, 2024
3 tasks
@fxmarty
Copy link
Contributor Author

fxmarty commented Jul 1, 2024

Failing tests are unrelated

@fxmarty fxmarty requested a review from IlyasMoutawwakil July 1, 2024 09:45
Copy link
Member

@IlyasMoutawwakil IlyasMoutawwakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some prints to remove but otherwise LGTM, thanks for the nice patch of mistral

@IlyasMoutawwakil
Copy link
Member

@fxmarty do you think it makes sense to also remove the constraint on numpy version as it's handled by transformers now ?

Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @fxmarty

.github/workflows/test_onnx.yml Outdated Show resolved Hide resolved
@fxmarty fxmarty merged commit 86adc3e into main Jul 1, 2024
60 of 64 checks passed
@fxmarty fxmarty deleted the transformer-442 branch July 1, 2024 16:03
@liammcinroy liammcinroy mentioned this pull request Jul 23, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants