Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows and onnx dtype compatibility #1886

Merged
merged 12 commits into from
Jun 24, 2024
Merged

Fix Windows and onnx dtype compatibility #1886

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
949743e
without io binding refacto
IlyasMoutawwakil Jun 3, 2024
13a6650
fix pkv and audio
IlyasMoutawwakil Jun 3, 2024
5734e56
fix
IlyasMoutawwakil Jun 3, 2024
67fc4a5
add t5 test
IlyasMoutawwakil Jun 3, 2024
aaf6cd6
fix seq2seq
IlyasMoutawwakil Jun 4, 2024
20ccd8e
fix vision2seq tests as it seems to have had always outputed kv cache…
IlyasMoutawwakil Jun 4, 2024
05582db
fix folder deletion on windows
IlyasMoutawwakil Jun 5, 2024
f770d85
Merge branch 'main' into fix-windows-int32
IlyasMoutawwakil Jun 5, 2024
06dbf89
fix temporary directory removal on windows
IlyasMoutawwakil Jun 5, 2024
d584a88
fix merge
IlyasMoutawwakil Jun 5, 2024
305b41a
remove attention_mask creation as ORTModelForxxx's corresponding proc…
IlyasMoutawwakil Jun 6, 2024
9587bc4
remove_directory utility function
IlyasMoutawwakil Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions tests/onnxruntime/test_modeling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,10 @@ def test_load_model_from_empty_cache(self):
dirpath = os.path.join(default_cache_path, "models--" + self.TINY_ONNX_MODEL_ID.replace("/", "--"))

if os.path.exists(dirpath) and os.path.isdir(dirpath):
shutil.rmtree(dirpath)
if os.name == "nt":
os.system(f"rmdir /S /Q {dirpath}")
else:
shutil.rmtree(dirpath)
IlyasMoutawwakil marked this conversation as resolved.
Show resolved Hide resolved
with self.assertRaises(Exception):
_ = ORTModel.from_pretrained(self.TINY_ONNX_MODEL_ID, local_files_only=True)

Expand All @@ -204,7 +207,10 @@ def test_load_seq2seq_model_from_empty_cache(self):
dirpath = os.path.join(default_cache_path, "models--" + self.TINY_ONNX_SEQ2SEQ_MODEL_ID.replace("/", "--"))

if os.path.exists(dirpath) and os.path.isdir(dirpath):
shutil.rmtree(dirpath)
if os.name == "nt":
os.system(f"rmdir /S /Q {dirpath}")
else:
shutil.rmtree(dirpath)
with self.assertRaises(Exception):
_ = ORTModelForSeq2SeqLM.from_pretrained(self.TINY_ONNX_SEQ2SEQ_MODEL_ID, local_files_only=True)

Expand All @@ -227,7 +233,10 @@ def test_load_stable_diffusion_model_from_empty_cache(self):
)

if os.path.exists(dirpath) and os.path.isdir(dirpath):
shutil.rmtree(dirpath)
if os.name == "nt":
os.system(f"rmdir /S /Q {dirpath}")
else:
shutil.rmtree(dirpath)
with self.assertRaises(Exception):
_ = ORTStableDiffusionPipeline.from_pretrained(
self.TINY_ONNX_STABLE_DIFFUSION_MODEL_ID, local_files_only=True
Expand Down