Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input_labels input to SAM model export #1638

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Conversation

xenova
Copy link
Contributor

@xenova xenova commented Jan 9, 2024

What does this PR do?

Adds support for supplying negative points in ONNX export.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@xenova xenova marked this pull request as ready for review January 11, 2024 16:19
@xenova
Copy link
Contributor Author

xenova commented Jan 11, 2024

Confirmed working correctly in transformers.js: huggingface/transformers.js#510
cc @fxmarty anything else before we merge? 😇

Also, in future, it would be nice to be able to export with boxes support. Will do as a follow-up

Copy link
Contributor

@fxmarty fxmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@fxmarty fxmarty merged commit 4d25ed2 into main Jan 11, 2024
45 of 48 checks passed
@fxmarty fxmarty deleted the sam-onnx-add-input-labels branch January 11, 2024 16:56
echarlaix pushed a commit that referenced this pull request Jan 19, 2024
* Add `input_labels` input to SAM model export

* Add back error guard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants