Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring EC2 CIs #1575

Merged
merged 5 commits into from
Dec 8, 2023
Merged

Refactoring EC2 CIs #1575

merged 5 commits into from
Dec 8, 2023

Conversation

JingyaHuang
Copy link
Contributor

What does this PR do?

Update GPU CIs with EC2 runners.

@JingyaHuang JingyaHuang added gpu-test trigger GPU tests training labels Dec 8, 2023
@JingyaHuang JingyaHuang requested a review from fxmarty December 8, 2023 14:43
@glegendre01
Copy link
Contributor

seems good

@JingyaHuang JingyaHuang mentioned this pull request Dec 8, 2023
Closed
4 tasks
fxmarty
fxmarty reviewed Dec 8, 2023
View reviewed changes
.github/workflows/doctests.yml
needs: start-runner # required to start the main job when the runner is ready
runs-on: ${{ needs.start-runner.outputs.label }} # run the job on the newly created runner
name: Start self-hosted EC2 runner
runs-on: [single-gpu, nvidia-gpu, t4, ci]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this work?

@JingyaHuang
Copy link
Contributor Author

So for self-hosted GPU tests, following CIs failed:

  • onnxruntime/training/nightly_test_examples.py I will take care of the training CI with the ORT team.
  • gptq/test_quantization.py gently pinging @fxmarty and @SunMarc
  • onnxruntime/test_modeling.py

I will get the PR merged despite failing tests, as the CIs are working well.

@JingyaHuang JingyaHuang merged commit e840d21 into huggingface:main Dec 8, 2023
39 of 43 checks passed
@JingyaHuang JingyaHuang deleted the refactor-ec2-cis branch December 8, 2023 16:32
@SunMarc SunMarc mentioned this pull request Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxmarty fxmarty fxmarty left review comments

@glegendre01 glegendre01 Awaiting requested review from glegendre01

Assignees
No one assigned
Labels
gpu-test trigger GPU tests training
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JingyaHuang @glegendre01 @fxmarty