Handling block_size value for models with no sequence length limit. #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
JingyaHuang
reviewed
Oct 26, 2023
JingyaHuang
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Looks good to me, thanks again for patching the example for a wider range of models! @AdamLouly
|
Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Models with no sequence length limit will fail to create a dataset because the block_size will be -1.
and it will error this:
ValueError: num_samples should be a positive integer value, but got num_samples=0this PR handles the case where max_position_embeddings is -1, we set block size to a default value.