New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix max_pos_embeddings error #1478

Merged

JingyaHuang merged 2 commits into huggingface:main from AdamLouly:adamlouly/fix_bloom_max_pos

Oct 24, 2023

Contributor

AdamLouly commented Oct 23, 2023

Changes Made

Added handling for configurations that may not have the max_position_embeddings attribute.
Introduced a default value of 1024 for max_position_embeddings when it's missing in the configuration.

Motivation and Context

Fixing this issue: Bloom failing after setting up max_position_embeddings on Trainer.py #1477
This PR addresses an issue where some configurations lack the max_position_embeddings attribute, causing failures in certain scenarios.


          fix max_pos_embeddings error

6eda00f

AdamLouly mentioned this pull request

Bloom failing after setting up max_position_embeddings on Trainer.py #1477

Closed

4 tasks


          fix lint

e79acc1

fxmarty requested a review from JingyaHuang

October 24, 2023 07:50

JingyaHuang approved these changes

View reviewed changes

Contributor

JingyaHuang left a comment

LGTM, thanks a lot for the fix! @AdamLouly

JingyaHuang merged commit 0b22218 into huggingface:main

48 of 50 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet