Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mistral models ONNX export support #1425

Merged
merged 12 commits into from
Oct 9, 2023
Merged

Add Mistral models ONNX export support #1425

merged 12 commits into from
Oct 9, 2023

Conversation

echarlaix
Copy link
Collaborator

No description provided.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 2, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@echarlaix echarlaix changed the title Add ONNX export Mistral models support Add Mistral models ONNX export support Oct 2, 2023
@echarlaix echarlaix added the gpu-test trigger GPU tests label Oct 2, 2023
@echarlaix echarlaix removed the gpu-test trigger GPU tests label Oct 2, 2023
@echarlaix echarlaix marked this pull request as ready for review October 6, 2023 09:22
@echarlaix echarlaix mentioned this pull request Oct 6, 2023
Merged
@echarlaix echarlaix requested a review from fxmarty October 6, 2023 12:28
fxmarty
fxmarty reviewed Oct 6, 2023
View reviewed changes
Copy link
Contributor

@fxmarty fxmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

optimum/onnxruntime/base.py Outdated Show resolved Hide resolved
optimum/onnxruntime/base.py Outdated Show resolved Hide resolved
optimum/onnxruntime/base.py Outdated Show resolved Hide resolved
@echarlaix
Copy link
Collaborator Author

thanks for catching it @fxmarty, added a fix in 4df6252

fxmarty
fxmarty approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@fxmarty fxmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a last comment

@echarlaix echarlaix mentioned this pull request Oct 9, 2023
Closed
@echarlaix echarlaix merged commit c98cb87 into main Oct 9, 2023
62 of 70 checks passed
@echarlaix echarlaix deleted the mistral branch October 9, 2023 08:52
This was referenced Oct 9, 2023
Closed
Closed
@xenova xenova mentioned this pull request Oct 18, 2023
Closed
@echarlaix echarlaix mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xenova xenova xenova left review comments

@fxmarty fxmarty fxmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@echarlaix @HuggingFaceDocBuilderDev @fxmarty @xenova