Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix index.mdx rendering #1423

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Fix index.mdx rendering #1423

merged 2 commits into from
Sep 29, 2023

Conversation

mishig25
Copy link

@mishig25 mishig25 commented Sep 29, 2023

Problem

Due to nested <a> elements, css style breaks

See broken here

Solution

Fix it by replacing <a> elements with <span> elements with on:click attribute

See fixed here

### Problem

Due to nested `<a>` elements, css style breaks

### Solution

Fix it by replacing `<a>` elements with `<span>` elements
@mishig25 mishig25 requested a review from regisss September 29, 2023 09:09
@regisss
Copy link
Contributor

regisss commented Sep 29, 2023

I just merged #1422 to have a quick fix (i.e. removing links).
Let's wait for the PR doc to be build to see how it renders.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 29, 2023

The documentation is not available anymore as the PR was closed or merged.

@mishig25
Copy link
Author

Copy link
Contributor

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot @mishig25 !!
I'm going to fix the merge conflicts with #1422 and will merge the PR.

@regisss regisss merged commit ca7b9d8 into main Sep 29, 2023
49 of 53 checks passed
@regisss regisss deleted the mishig25-patch-1 branch September 29, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants