Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ORT execution provider test for onnxruntime v1.16.0 #1406

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Fix ORT execution provider test for onnxruntime v1.16.0 #1406

merged 1 commit into from
Sep 21, 2023

Conversation

echarlaix
Copy link
Collaborator

Since #1403 the ImportError will never be raised

optimum/optimum/onnxruntime/utils.py

Lines 225 to 227 in 3c4ad78

version.parse(ort.__version__) < version.parse("1.16.0")
and os.name != "nt"
and provider in ["CUDAExecutionProvider", "TensorrtExecutionProvider"]

@echarlaix echarlaix requested a review from fxmarty September 21, 2023 17:55
@echarlaix echarlaix merged commit 6d1ae0e into main Sep 21, 2023
48 of 52 checks passed
@echarlaix echarlaix deleted the fix-test branch September 21, 2023 17:55
echarlaix added a commit that referenced this pull request Sep 21, 2023
@echarlaix
Fix ORT execution provider test for onnxruntime v1.16.0 (#1406)
b25b66b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxmarty fxmarty Awaiting requested review from fxmarty

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@echarlaix