-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ORT Training] Some important updates of ONNX Runtime training APIs #1335
[ORT Training] Some important updates of ONNX Runtime training APIs #1335
Conversation
#1327 should already be fixed |
Co-authored-by: fxmarty <[email protected]>
yeah @fxmarty I forgot to update the description, thanks a lot for the fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, hopefully adding position_ids
inputs did not break ORTTrainer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ORTTrainer
to 4.33.1
All tests passed:
Left an example test skipped, need to add similar tests for other tasks. |
What does this PR do?
ORTTrainer
to be compatible with transformers 40ea9ab2a1ad99f12e71c3a26215ad33df082ef9.[Deprecation notes]
The Optimum team decided to deprecate the evaluation and prediction using ONNX Runtime for the reasons below:
ORTTrainer
. If you want to do inference with ORT, either the evaluation or the prediction can be done through ORTModels in the library.ORTTrainer
and training examples[Other subjects to discuss]