Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Optimum to 1.22 + Adapt to the SD task refactoring in Optimum main #686

Merged
merged 8 commits into from
Sep 20, 2024

Conversation

JingyaHuang
Copy link
Collaborator

What does this PR do?

Make optimum-neuron compatible with changes in huggingface/optimum#1947. Besides, with the changes, the InstructPix2Pix support in Optimum Neuron will fail, a PR is opened in Optimum repo to patch this: huggingface/optimum#1999.

Merge this only when we bump to a stable Optimum release including the two PRs mentioned above.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@JingyaHuang JingyaHuang changed the title [DO NOT MERGE] Adapt to the SD task refactoring in Optimum main Bump Optimum to 1.22 + Adapt to the SD task refactoring in Optimum main Sep 19, 2024
@JingyaHuang JingyaHuang marked this pull request as ready for review September 19, 2024 10:14
Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull-request. It looks good to me except for the changes in test_modeling.py that I did not understand.

tests/inference/test_modeling.py Outdated Show resolved Hide resolved
@JingyaHuang JingyaHuang requested a review from dacorvo September 20, 2024 07:22
Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the pull-request !

@JingyaHuang JingyaHuang merged commit 8445656 into main Sep 20, 2024
10 of 12 checks passed
@JingyaHuang JingyaHuang deleted the bump-optimum-after-task-refactoring branch September 20, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants