Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable export=False in IPEXModel #626

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

jiqing-feng
Copy link
Collaborator

Hi @echarlaix . I think we should disable export=False in IPEXModel because we propose that the ipex optimization contains jit.trace. After this PR merged, I could update the ipex example and readme (#594 #595 ) to clarify it. Thx

@jiqing-feng jiqing-feng marked this pull request as ready for review March 22, 2024 04:57
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@echarlaix echarlaix merged commit 3c7245a into huggingface:main Mar 26, 2024
10 checks passed
@jiqing-feng jiqing-feng deleted the ipex_export branch October 9, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants