apply bettertransformer by default for causallm #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
echarlaix
approved these changes
Mar 15, 2024
sandye51
reviewed
Mar 17, 2024
| @@ -299,7 +299,7 @@ def export_pytorch( | |||
| logger.info(f"Using framework PyTorch: {torch.__version__}") | |||
| output = Path(output) | |||
|
|
|||
| if stateful: | |||
| if ensure_export_task_support_stateful(config.task): | |||
| # Trigger bettertransformer together with stateful model because OpenVINO HW-dependent transformations expect | |||
| # both of them are applied to demonstrate the best performance. | |||
| # TODO: Consider applying bettertransformer regardless of stateful flag -- requires additional validation. | |||
|
@echarlaix sorry, I forgot to mark this as draft there were no intention to merge it right now, we wanted validate these changes internally to make decision that it does not affect stateless models and it is anyway works incorrectly (here proper enabling #610 - draft until we are validating it on large models scope), pr with revert these changes #612 |
echarlaix
pushed a commit
that referenced
this pull request
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
align stateful and stateless IRs for causallm