-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add confusion matrix #528
Add confusion matrix #528
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Actually looks like the doctests are failing. Did you test if the docstring example result match reality? |
It should be good now :) |
Sorry for all the noise with the commits. After some testing, I could pinpoint the issue of different string representations in Windows vs Ubuntu. E.g. Ubuntu
Windows
An alternative would be to just print the shape or sum of the confusion matrix, but this loses a bit of the point. This is also a bit confusing because other metrics such as |
Ok - the solution was to use ellipsis so it works with or without |
Thanks for fixing it. Looks all good! |
This PR adds the confusion matrix metric. Some flake errors forced me to change two small type checks.