-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the documentation and citation of mauve #416
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Can you run metrics/mauve/mauve.py:45:190: W291 trailing whitespace
[17](https://github.com/huggingface/evaluate/actions/runs/4117623810/jobs/7109147950#step:5:18)
metrics/mauve/mauve.py:47:153: W291 trailing whitespace
[18](https://github.com/huggingface/evaluate/actions/runs/4117623810/jobs/7109147950#step:5:19)
metrics/mauve/mauve.py:48:155: W291 trailing whitespace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, once the make style && make quality
are done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can merge once style and quality is fixed.
Hi Leandro, sorry I dropped the ball on this one. Is there anything action required from my side here? Also, possibly unrelated, but it appears that Mauve's space is broken for some reason. Is there anything I can do to help fix it? Thank you very much! |
@lvwerra Thank you so much for fixing the whitespace and it looks like all checks have passed. Can this PR be merged now? |
No description provided.