Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect resume_download deprecation #7843

Merged
merged 5 commits into from
May 3, 2024
Merged

Conversation

Wauplin
Copy link
Collaborator

@Wauplin Wauplin commented May 2, 2024

In huggingface_hub==0.23.0, resume_download has been deprecated since downloads are now always resumed when possible. The goals of this PR are:

  • avoid warning by setting the default to None (instead of False)
  • update the docstring to show it is deprecated

More details in huggingface/transformers#30620 (same purpose of this PR).

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me to merge once the CI is green. Thanks so much, Lucain!

@sayakpaul sayakpaul requested review from DN6 and yiyixuxu May 3, 2024 01:49
@Wauplin
Copy link
Collaborator Author

Wauplin commented May 3, 2024

Merging it now since CI is green. Thanks for the review @sayakpaul! :)
(CI failure was due to code quality)

@Wauplin Wauplin merged commit 6a47958 into main May 3, 2024
17 checks passed
XSE42 added a commit to XSE42/diffusers3d that referenced this pull request May 13, 2024
diffusers commit 6a47958
    Respect `resume_download` deprecation huggingface/diffusers#7843
sayakpaul added a commit that referenced this pull request Dec 23, 2024
* Deprecate resume_download

* align docstring with transformers

* style

---------

Co-authored-by: Sayak Paul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants