Let server decide default repo visibility #10047
Open
+9
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
pcuenca
approved these changes
Nov 28, 2024
Comment on lines
+567
to
+568
| Whether to make the repo private. If `None` (default), the repo will be public unless the | ||
| organization's default is private. This value is ignored if the repo already exists. |
There was a problem hiding this comment.
Maybe link to the appropriate docs for enterprise orgs?
There was a problem hiding this comment.
I'd rather keep it simple (+ a bit lazy to update the 5 other PRs I've opened on other HF libraries 😄)
|
(I cannot merge myself btw so I'll let a diffusers maintainer do it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, all repos were public by default when created without passing the
privateargument. This meant that passingprivate=Falseorprivate=Nonewas strictly the same. This is not the case anymore. Enterprise Hub offers organizations to set a default visibility setting for new repos. This is useful for organizations forbidding public repos for security matters. This PR mostly updates some docstrings + default values so thatprivate=Noneis always passed when user don't set it manually.This PR doesn't create any breaking change. The real update has been done server-side when introducing the new Enterprise Hub feature. Related to huggingface/huggingface_hub#2679.