Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for typos in C4_W3_Lab2, C4_W3_Lab3 and C4_W3_Lab4 #114

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,7 @@
"source": [
"### Standard ExampleGen code\n",
"\n",
"TFX is open source so the code for standard components can easily be found the public [repo](https://github.com/tensorflow/tfx/tree/89d3cb6c59acd0d487916bff703711815f1506b5/tfx). We placed links in the following sections of the actual files that you'll be modifying/overriding in case you want to compare what was changed for your custom ExampleGen. \n",
"TFX is open source so the code for standard components can easily be found in the public [repo](https://github.com/tensorflow/tfx/tree/89d3cb6c59acd0d487916bff703711815f1506b5/tfx). We placed links in the following sections of the actual files that you'll be modifying/overriding in case you want to compare what was changed for your custom ExampleGen. \n",
"\n",
"The class heirarchy for these components is pretty deep but in summary, you will only need to modify three:\n",
"\n",
Expand Down Expand Up @@ -1055,4 +1055,4 @@
]
}
]
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ To test the different model versions you can use the `dog_example.json` file tha

Since you defined labels for the versions of the models you can consume them either by using numerical versioning or labels.

Begin by sending a `POST` request to version 1 of the model:
Begin by sending a `POST` request to version 2 of the model:

```bash
curl -X POST http://localhost:8501/v1/models/animals/versions/2:predict \
Expand Down
12 changes: 6 additions & 6 deletions course4/week3-ungraded-labs/C4_W3_Lab_4_Github_Actions/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -134,12 +134,12 @@ In the next part you need to define all of the jobs than will run when this acti
steps:
-
name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
-
name: Set up Python
uses: actions/setup-python@v2
uses: actions/setup-python@v4
with:
python-version: '3.7.7'
python-version: '3.8'
-
name: Install dependencies
run: |
Expand All @@ -155,16 +155,16 @@ In the next part you need to define all of the jobs than will run when this acti
Finally you need to specify the `steps` for this action to be completed. This is a sequence of commands to achieve the functionality you strive for. `steps` have several values associated such as:
- `name`: The name of the step.

- `uses`: You can specify an already existing `Action` as an step on one of your own. This is pretty cool because it allows for reutilization of Actions.
- `uses`: You can specify an already existing `Action` as a step on one of your own. This is pretty cool because it allows for reutilization of Actions.
- `run`: Instead of using an existing Action you might need to run a command. Since you are using `bash` inside a Linux VM, these commands should follow the correct syntax.
- `with`: You might need to specify some additional values. This field is for such cases.


Let's understand every step in order:

- The first step uses the `actions/checkout@v2` Action. This is usually included in every Action since it allows GitHub to access or check-out your repo.
- The first step uses the `actions/checkout@v4` Action. This is usually included in every Action since it allows GitHub to access or check-out your repo.

- Now that your repo has been checked-out, you need to set an environment capable of running your Python code. To accomplish this the `actions/setup-python@v2` Actions is used while specifying the desired Python version.
- Now that your repo has been checked-out, you need to set an environment capable of running your Python code. To accomplish this the `actions/setup-python@v4` Actions is used while specifying the desired Python version.
- Having a Python supported environment it is time to install of the dependencies that your application needs. You can do so by using upgrading `pip` and then using it to install the dependencies listed in the `requirements.txt` file.
- Finally you can run your unit tests by simply using the `pytest` command. Notice that you needed to `cd` into the `app` directory first.

Expand Down