Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to fs2-data-xml #3

Merged
merged 72 commits into from
Oct 5, 2022
Merged

Switch to fs2-data-xml #3

merged 72 commits into from
Oct 5, 2022

Conversation

rossabaker
Copy link
Member

Replaces the SAX parser with fs2-data-xml. This is a continuation of http4s/http4s-scala-xml#25.

rossabaker and others added 30 commits June 4, 2022 22:47
@rossabaker
Create .scalafix.conf
0c6b732
@http4s-steward
Update sbt-http4s-org to 0.13.4 in series/0.23
0422cac
@http4s-steward
Update scalafmt-core to 3.5.8 in series/0.23
1ccc4fe
@rossabaker
Merge pull request http4s/http4s-scala-xml#18 from http4s/update/seri…
a034fbd 
…es/0.23/sbt-http4s-org-0.13.4

Update sbt-http4s-org to 0.13.4 in series/0.23
@rossabaker
Merge pull request http4s/http4s-scala-xml#19 from http4s/update/seri…
89ac767 
…es/0.23/scalafmt-core-3.5.8

Update scalafmt-core to 3.5.8 in series/0.23
@http4s-steward
Update sbt-http4s-org to 0.14.2 in series/0.23
5abf695
@http4s-steward
Regenerate workflow with sbt-github-actions
093181b
@rossabaker
Create .scalafix.conf
ad64058
@rossabaker
Merge pull request http4s/http4s-scala-xml#22 from http4s/update/seri…
2a18cf9 
…es/0.23/sbt-http4s-org-0.14.2

Update sbt-http4s-org to 0.14.2 in series/0.23
@rossabaker
Merge pull request http4s/http4s-scala-xml#16 from http4s/create-scal…
e9d04b3 
…afix.conf

Create .scalafix.conf
@http4s-steward
Update scala-library to 2.12.16 in series/0.23
c75cdd2
@http4s-steward
Regenerate workflow with sbt-github-actions
79ed8e2
@armanbilge
First try at fs2-data parser
c6d4f23
@http4s-steward
Update sbt-http4s-org to 0.14.3 in series/0.23
c76c499
@http4s-steward
Regenerate workflow with sbt-github-actions
5842c9e
@armanbilge
Merge pull request http4s/http4s-scala-xml#26 from http4s/update/seri…
498b2a5 
…es/0.23/sbt-http4s-org-0.14.3

Update sbt-http4s-org to 0.14.3 in series/0.23
@rossabaker
Merge pull request http4s/http4s-scala-xml#24 from http4s/update/seri…
c315f5d 
…es/0.23/scala-library-2.12.16

Update scala-library to 2.12.16 in series/0.23
@armanbilge
Embrace 0.24 bump
4fa217b
@armanbilge
Decode documents instead of elements
a96dc38
@armanbilge
Cross-build for Scala.js
2edad74
@armanbilge
Fix docs
9146293
@armanbilge
Formatting
1ea9523
@armanbilge
Factor out an xml event stream decoder
27fe543
@armanbilge
Bikeshed
78fcdc0
@rossabaker
Mark the loadXML call as blocking
897d22c
@rossabaker
Fix deprecated doc
d82d827
@rossabaker
Merge pull request http4s/http4s-scala-xml#28 from http4s/load-xml-is…
1f198da 
…-blocking

Mark the loadXML call as blocking
@rossabaker
Rudimentary XML generator and round-trip test
98d7ced
@rossabaker
Generate normalized attribute values
0797724
@rossabaker
Merge pull request http4s/http4s-scala-xml#30 from http4s/xml-generator
5f8f1f5 
Rudimentary XML generator and round-trip test
@rossabaker
Merge pull request #12 from http4s/update/http4s-core-0.23.14
89da9d1 
Update http4s-core, http4s-laws, ... to 0.23.14
ybasket
ybasket reviewed Aug 30, 2022
View reviewed changes
build.sbt Outdated

val http4sVersion = "0.23.12"
val scalaXmlVersion = "2.1.0"
val fs2DataVersion = "1.4.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
val fs2DataVersion = "1.4.0"
val fs2DataVersion = "1.5.0"

That should the charset-related exception the tests caught before.

@ybasket ybasket mentioned this pull request Sep 2, 2022
Merged
@armanbilge
Copy link
Member

@ybasket wdyt about just making this branch into the new main and resetting the versioning to start from 0.1 or whatever?

@ybasket
Copy link
Contributor

ybasket commented Sep 18, 2022

@ybasket wdyt about just making this branch into the new main and resetting the versioning to start from 0.1 or whatever?

@armanbilge sounds good to me.

@armanbilge armanbilge changed the base branch from series/0.23 to main September 18, 2022 15:26
armanbilge
armanbilge reviewed Sep 18, 2022
View reviewed changes
build.sbt Outdated Show resolved Hide resolved
@armanbilge
Copy link
Member

Hum, seems I don't have the capability to change the default branch. @rossabaker? 😅

@ybasket
Copy link
Contributor

ybasket commented Oct 5, 2022

Merging this now to not block further development, we can still swap branches later on.

@ybasket ybasket merged commit c1d70c2 into main Oct 5, 2022
@armanbilge armanbilge deleted the fs2-data branch October 5, 2022 19:26
@rossabaker
Copy link
Member Author

Sorry, I'm confused by the branch switch request. What needs to go where?

@armanbilge
Copy link
Member

@rossabaker we want to make main the default branch, instead of series/0.23. Indeed, we want to reset the versioning and start from 0.1.

@rossabaker
Copy link
Member Author

Branch is switched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge left review comments

@ybasket ybasket ybasket left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rossabaker @armanbilge @ybasket