Row.c code shrink and adding a new format for Row_printNanoseconds() #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reduce length of the format strings by removing redundant field width specifications (e.g. "%1u" -> "%u"). * Merge some identical function calls in conditionals. Signed-off-by: Kang-Che Sung <[email protected]>
Shorten a format string ("%1ud" -> "%ud").
Signed-off-by: Kang-Che Sung <[email protected]>
Merge two xSnprintf() calls within the function. When the time value to print is less than one second, the "%.u" format allows us to print no digits in the seconds field. Signed-off-by: Kang-Che Sung <[email protected]>
Add a new format: "1.0000ms" - "9.9999ms". Previously they would print as ".001000s" and ".009999s", and this new format adds one extra digit of precision. Note that I print the unit as "ms" rather than microseconds; this saves code for deciding whether to print the Greek "mu" or the Latin "u". Row_printNanoseconds() now prints this list of formats: " 0ns", "999999ns", "1.0000ms", "9.9999ms", ".010000s", ".999999s", "1.00000s", "59.9999s", "1:00.000", "9:59.999", "10:00.00" ... Signed-off-by: Kang-Che Sung <[email protected]>
Explorer09
force-pushed
the
print-time-format
branch
from
0c14007 to
46e88a9
Compare
BenBE
approved these changes
Jan 2, 2025
"1.0000ms" vs. "1000.0us" ... These are same precision for showing the fractions of a second. I don't know which one looks better. Note that the time units in the GPUMeter would have to use |
|
I'm neutral either way … |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first three commits are code shrinks.
The last one commit adds a new format for Row_printNanoseconds() because I feel I missed a chance of allowing one extra digit of precision to be printed.
The last commit is optional. If people feel the new format is not worth it, I can drop that commit.
(Follow-up of #1425)