Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kafka): verify coordinator for describe groups request #1795

Merged
merged 2 commits into from
May 10, 2024

Conversation

YangKian
Copy link
Contributor

PR Description

Type of change

  • Bug fix

Checklist

  • I have run format.sh under script
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

@4eUeP 4eUeP marked this pull request as draft April 19, 2024 07:42
@YangKian YangKian force-pushed the fix-group branch 2 times, most recently from 2537c59 to d790d2a Compare May 7, 2024 03:35
@YangKian YangKian marked this pull request as ready for review May 7, 2024 03:36
@Commelina
Copy link
Contributor

Split node checking & log modification into other (two) PRs? I am not sure.

@YangKian
Copy link
Contributor Author

YangKian commented May 8, 2024

Split node checking & log modification into other (two) PRs? I am not sure.

Or you can merge #1811 first, then I will fix lookup and other part later

@YangKian YangKian changed the title fix(kafka): DescribeGroup shouldn't return an error when encounter a non-existent groupId fix(kafka): verify coordinator for describe groups request May 10, 2024
@YangKian YangKian requested a review from Commelina May 10, 2024 03:24
@YangKian YangKian merged commit 35d0792 into hstreamdb:main May 10, 2024
24 checks passed
@YangKian YangKian deleted the fix-group branch May 10, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants