Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hstream-kafka-client: init #1620

Closed
wants to merge 5 commits into from
Closed

hstream-kafka-client: init #1620

wants to merge 5 commits into from

Conversation

alissa-tung
Copy link
Contributor

@alissa-tung alissa-tung commented Sep 25, 2023 •
edited
Loading

PR Description

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation updates required

Summary of the change and which issue is fixed

Main changes: TODO

Checklist

  • I have run format.sh under script
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

@alissa-tung alissa-tung marked this pull request as ready for review September 26, 2023 09:19
@alissa-tung
Copy link
Contributor Author

cc @daleiz

4eUeP
4eUeP requested changes Sep 28, 2023
View reviewed changes
hstream-kafka/protocol/Kafka/Protocol/Message.hs Outdated Show resolved Hide resolved
hstream-kafka/protocol/Kafka/Network.hs Show resolved Hide resolved
hstream-kafka/app/Main.hs Outdated Show resolved Hide resolved
hstream-kafka/hstream-kafka.cabal Outdated Show resolved Hide resolved
@alissa-tung alissa-tung requested a review from 4eUeP September 28, 2023 07:40
@4eUeP
Copy link
Member

4eUeP commented Oct 9, 2023

Close via #1634

@4eUeP 4eUeP closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4eUeP 4eUeP Awaiting requested review from 4eUeP

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alissa-tung @4eUeP