Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation #35

Open
bhavitvyamalik opened this issue Aug 1, 2024 · 6 comments
Open

Improve documentation #35

bhavitvyamalik opened this issue Aug 1, 2024 · 6 comments
Assignees
Labels
documentation Improvements or additions to documentation tech debt Technical debt

Comments

@bhavitvyamalik
Copy link

We need to have detailed documentation for running OpusPocus on both slurm and bash. The current documentation is good for setting up OpusPocus but there are few gaps when running the pipeline.

@bhavitvyamalik bhavitvyamalik added this to the MVP - August 31, 2024 milestone Aug 1, 2024
@rggdmonk rggdmonk added documentation Improvements or additions to documentation tech debt Technical debt labels Aug 1, 2024
@bhaddow
Copy link
Contributor

bhaddow commented Aug 2, 2024

Could you give step-by-step instructions for "preparing the virtual environments for OpusCleaner and OpusPocus". Also what to do if you want to use conda instead?

@varisd
Copy link
Contributor

varisd commented Aug 2, 2024

I use the following:

$ /path/to/virtualenv -p /path/to/python-3.10.X/bin/python3 /virtual/environment/destination/opuspocus
$ source /virtual/environment/destination/opuspocus/bin/activate
$ pip install --upgrade pip setuptools
$ pip install -r requirements.txt

$ /path/to/virtualenv -p /path/to/python-3.10.X/bin/python3 /virtual/environment/destination/opuscleaner
$ source /virtual/environment/destination/opuscleaner/bin/activate
$ pip install --upgrade pip setuptools
$ pip install -r requirements-opuscleaner.txt 

Get the requirements-opuscleaner.txt from the opuscleaner repository. Alternatively, you can try replacing pip install -r requirements-opuscleaner.txt with pip install opuscleaner in the opuscleaner vitualenv.
If I remember correctly, the approach should be similar to conda, only the environment activation differs. For execution you pass the root directory of the virtual environment and the respective python executable is called by opuspocus (should not matter if its virtualenv or conda - but it needs testing for confirmation).

@bhaddow
Copy link
Contributor

bhaddow commented Aug 2, 2024

I meant, should this be in the documentation. It's maybe worth spelling out.

@varisd
Copy link
Contributor

varisd commented Aug 2, 2024

We can put it in README.txt in the installation section. Although, ideally, OpusCleaner and OpusTrainer (the pipy versions) should not have conflicting dependencies, thus requiring only a single virtual env for OpusPocus (which has OpusTrainer as its pipy dependency).

@bhaddow
Copy link
Contributor

bhaddow commented Aug 2, 2024

Yes, it would be ideal if we could remove the conflicts. I think then we would need some automated check (CI pipeline) to ensure that conflicts were not re-introduced, assuming both projects will be actively developed.

@bhaddow
Copy link
Contributor

bhaddow commented Aug 6, 2024

This is incomplete

$ /path/to/virtualenv -p /path/to/python-3.10.X/bin/python3 /virtual/environment/destination/opuspocus
$ source /virtual/environment/destination/opuspocus/bin/activate
$ pip install --upgrade pip setuptools
$ pip install -r requirements.txt

You also need to run pip install . in the OpusPocus directory. (which fails). See #42

@varisd varisd self-assigned this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation tech debt Technical debt
Projects
None yet
Development

No branches or pull requests

4 participants