Increase robustnesss of historic bench results parsing

hpi-swa-lab · Jan 9, 2022 · 2cd976a · 2cd976a · github-actions · Jan 9, 2022
1 parent 4830ca6
commit 2cd976a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/...ges/TraceDebuggerBenchmarks.package/TDBBenchmarkRunner.class/class/parseHistoricBench..st b/...ges/TraceDebuggerBenchmarks.package/TDBBenchmarkRunner.class/class/parseHistoricBench..st
@@ -8,11 +8,12 @@ parseHistoricBench: bench
 
 	benchmark privateTimeToRun: bench value milliSeconds.
 	bench extra ifNotNil: [
-		| extra |
+		[| extra |
 		extra := Json readFrom: bench extra readStream.
 		benchmark
 			privateTotalTime: extra totalTime milliSeconds;
 			privatePreparationTime: extra preparationTime milliSeconds;
-			privatePostparationTime: extra postparationTime milliSeconds].
+			privatePostparationTime: extra postparationTime milliSeconds]
+				ifError: [:msg | Transcript showln: msg "sigh, we pushed some invalid data in the past..."]].
 
 	^ benchmark
diff --git a/packages/TraceDebuggerBenchmarks.package/TDBBenchmarkRunner.class/methodProperties.json b/packages/TraceDebuggerBenchmarks.package/TDBBenchmarkRunner.class/methodProperties.json
@@ -6,7 +6,7 @@
 		"historicDataUrl" : "ct 1/8/2022 22:35",
 		"historicRawData" : "ct 1/8/2022 22:41",
 		"historicTimesToRun" : "ct 1/8/2022 22:55",
-		"parseHistoricBench:" : "ct 1/9/2022 02:00",
+		"parseHistoricBench:" : "ct 1/9/2022 02:11",
 		"parseHistoricRawData:" : "ct 1/9/2022 01:52",
 		"run" : "ct 1/8/2022 15:39",
 		"testSelector" : "ct 1/8/2022 15:38" },
Benchmark suite	Current: `2cd976a`	Previous: `4830ca6`	Ratio
`TraceDebuggerBenchmark>>#benchStepOver`	`1484.6666666666667` Milliseconds (`stdev: 8802.333333333334`)	`1484.3333333333333` Milliseconds (`stdev: 12082.333333333334`)	`1.00`
`TDBRetracingSimulatorBenchmark>>#benchFactorial`	`2530` Milliseconds (`stdev: 157.0`)	`2511.6666666666665` Milliseconds (`stdev: 652.3333333333334`)	`1.01`
`TDBRetracingSimulatorBenchmark>>#benchProxyImageForm`	`1068` Milliseconds (`stdev: 661.0`)	`1064.6666666666667` Milliseconds (`stdev: 426.3333333333333`)	`1.00`
`TraceDebuggerBenchmark>>#benchExpandAll`	`2572.6666666666665` Milliseconds (`stdev: 50.333333333333336`)	`2520` Milliseconds (`stdev: 11491.0`)	`1.02`
`TDBRetracingSimulatorBenchmark>>#benchRegex`	`4562.333333333333` Milliseconds (`stdev: 7934.333333333333`)	`4510.666666666667` Milliseconds (`stdev: 146.33333333333334`)	`1.01`