Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/settings #953

Merged
merged 26 commits into from
Jun 10, 2021
Merged

Enhancement/settings #953

merged 26 commits into from
Jun 10, 2021

Conversation

T4rikA
Copy link
Contributor

@T4rikA T4rikA commented Jun 8, 2021 •
edited by linusha
Loading

Closes #403

  • I have added additional features that should now be part of the PR template. I made the necessary changes to the template.
  • I have fixed a bug/the added functionality should not be part of the PR template.
    • I added a test/ tests.
  • I have run all our tests and they still work.

@linusha linusha force-pushed the enhancement/settings branch from 28b9e1b to 147b3eb Compare June 8, 2021 14:11
@linusha linusha marked this pull request as ready for review June 8, 2021 14:27
frcroth
frcroth requested changes Jun 8, 2021
View reviewed changes
.github/pull_request_template.md Outdated Show resolved Hide resolved
editor.js Outdated Show resolved Hide resolved
editor.js Outdated Show resolved Hide resolved
editor.js Outdated Show resolved Hide resolved
editor.js Outdated Show resolved Hide resolved
editor.js Outdated Show resolved Hide resolved
interactive.js Outdated Show resolved Hide resolved
@linusha linusha force-pushed the enhancement/settings branch from e99f728 to 3a2422e Compare June 8, 2021 16:20
T4rikA
T4rikA commented Jun 8, 2021
View reviewed changes
editor.js Outdated Show resolved Hide resolved
@linusha linusha requested a review from frcroth June 8, 2021 16:45
@T4rikA T4rikA linked an issue Jun 8, 2021 that may be closed by this pull request
Aspect ratio of interactive #951
Closed
Paula-Kli
Paula-Kli reviewed Jun 9, 2021
View reviewed changes
editor.js Outdated Show resolved Hide resolved
editor.js Outdated Show resolved Hide resolved
Paula-Kli
Paula-Kli reviewed Jun 9, 2021
View reviewed changes
editor.js Outdated Show resolved Hide resolved
frcroth
frcroth requested changes Jun 9, 2021
View reviewed changes
.github/pull_request_template.md Outdated Show resolved Hide resolved
editor.js Show resolved Hide resolved
editor.js Outdated Show resolved Hide resolved
editor.js Outdated Show resolved Hide resolved
interactive.js Outdated Show resolved Hide resolved
utilities/messages.js Outdated Show resolved Hide resolved
frcroth
frcroth approved these changes Jun 9, 2021
View reviewed changes
editor.js Show resolved Hide resolved
@SilvanVerhoeven SilvanVerhoeven mentioned this pull request Jun 10, 2021
Closed
linusha and others added 11 commits June 10, 2021 17:28
@linusha @T4rikA
Add Settings Button in MenuBar
6a1fbdf 
Co-authored-by: T4rikA <[email protected]>
@linusha @T4rikA
Add settings options for name and scrollBar in Interactive
4f1f7dd
@T4rikA
Add check to only open one window settings at a time
8da7d85
@T4rikA @linusha
Add aspect ratio input field
456bbd9 
Co-authored-by: linusha <[email protected]>
@T4rikA @linusha
Finish Settings Menu
31dd27e 
Co-authored-by: linusha <[email protected]>
@linusha @T4rikA
Remove unused imports
65278d6 
Co-authored-by: T4rikA <[email protected]>
@linusha @T4rikA
Close menu in all scenarios and disconnect interactive upon ejection
42cd936 
Co-authored-by: T4rikA <[email protected]>
@linusha @T4rikA
Bring settings to front
7a48353 
Co-authored-by: T4rikA <[email protected]>
@linusha @T4rikA
Fix checkbox label
e820b07 
Co-authored-by: T4rikA <[email protected]>
@T4rikA
Adjust PR template
5a3219e
@linusha @Paula-Kli @T4rikA
Make the linter happy
be0c5eb 
Co-authored-by: Paula-Kli <[email protected]>
linusha and others added 14 commits June 10, 2021 17:29
@linusha @T4rikA
Make changing aspect Ratio work and fix zooming in Interactive
2aa570f 
Co-authored-by: linusha <[email protected]>
@linusha @frcroth @T4rikA
Remove empty line
81d57df 
Co-authored-by: frcroth <[email protected]>
@linusha @frcroth @T4rikA
Improve language in PR template
cbd749d 
Co-authored-by: frcroth <[email protected]>
@linusha @T4rikA
Use QinoqMorph correctly, add success method and restructure imports
ab31f5f 
Co-authored-by: T4rikA <[email protected]>
@linusha @T4rikA
Fix closing behavior of settings menu
bcc2fba 
Co-authored-by: T4rikA <[email protected]>
@linusha @T4rikA
Fix saving with Settings menu opened
994e0d4 
Co-authored-by: T4rikA <[email protected]>
@T4rikA @Paula-Kli
Add UI property for settings
5ac4ac1 
Refactor check box creation

Co-authored-by: Paula-Kli <[email protected]>
@T4rikA
Move settings to ui and remove settings property in editor
c5063e9
@T4rikA @Paula-Kli
Change success message to Ratio updated
3703235 
Co-authored-by: Paula-Kli <[email protected]>
@T4rikA
Refactor initalize procedure for settings
c576261
@T4rikA @frcroth
Refactor comment and success message
ea3bd80 
Fix tzpo in PR template

Co-authored-by: frcroth <[email protected]>
@T4rikA @linusha
Update success message
21222f5 
Co-authored-by: linusha <[email protected]>
@T4rikA @linusha
Change eval to regex
32b0429 
Add test for regex

Co-authored-by: linusha <[email protected]>
@linusha @T4rikA
Add changing the aspect ratio to PR template
198891a
SilvanVerhoeven
SilvanVerhoeven reviewed Jun 10, 2021
View reviewed changes
interactive.js Outdated Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
@T4rikA T4rikA force-pushed the enhancement/settings branch from 382a254 to 685dd5a Compare June 10, 2021 15:44
@T4rikA T4rikA merged commit 75c7d6a into dev Jun 10, 2021
@T4rikA T4rikA deleted the enhancement/settings branch June 10, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SilvanVerhoeven SilvanVerhoeven SilvanVerhoeven left review comments

@linusha linusha linusha left review comments

@Paula-Kli Paula-Kli Paula-Kli approved these changes

@frcroth frcroth frcroth approved these changes

Assignees

@linusha linusha

@T4rikA T4rikA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Aspect ratio of interactive Settings for interactives
5 participants
@T4rikA @frcroth @linusha @SilvanVerhoeven @Paula-Kli