Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-8556 implement request logging in nestjs #5401

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

BC-8556 implement request logging in nestjs #5401

wants to merge 13 commits into from

Conversation

Loki-Afro
Copy link
Member

@Loki-Afro Loki-Afro commented Dec 16, 2024 •
edited
Loading

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-8556

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

@Loki-Afro Loki-Afro changed the title BC-8559 implement request logging in nestjs BC-8556 implement request logging in nestjs Dec 16, 2024
bischofmax and others added 6 commits December 16, 2024 09:43
@bischofmax @Loki-Afro
BC-7906 - Remove tldraw legacy code (#5390)
cd10483
@MarvinOehlerkingCap @Loki-Afro
N21-2313 Improve schulconnex group provisioning runtime (#5394)
41a2a8d
@MarvinOehlerkingCap @Loki-Afro
N21-2317 Skip failed migrations in migration wizard (#5398)
764535f
@hoeppner-dataport @Metauriel @Loki-Afro
BC-8519 - add room owner role (#5393)
b6c27cf 
* add roomadmin and roomowner roles

* remove room_delete permission from roomeditor

* creating room memberships is now an operation seperate from adding users.
** creating a room memberships adds a user as owner
** adding a user fails if no membership exists yet

* fix room membership rule to use room role to check permissions

* ensure that room owners can not be removed from a room

---------

Co-authored-by: Thomas Feldtkeller <[email protected]>
@Loki-Afro
BC-8571 adding index to files.securityCheck.requestToken (#5399)
811b693
@Loki-Afro
Merge branch 'main' into bc-8556
ab5050c
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
18 Uncovered Lines on New Code (required ≤ 0)

See analysis details on SonarQube Cloud

@CeEv
Copy link
Contributor

CeEv commented Dec 17, 2024

The middleware want to have spec.ts. @Loki-Afro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CeEv CeEv CeEv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Loki-Afro @CeEv @bischofmax @MarvinOehlerkingCap @hoeppner-dataport