Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-8572 - room members are always added as admins #5400

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

Metauriel
Copy link
Contributor

@Metauriel Metauriel commented Dec 13, 2024

Description

As the feature to change user roles will be added in Q1/2025 - teachers that get added need to be able to add/remove RoomMembers from their school.
In order to avoid migrations and unexpacted/confusing changes in their rights, new RoomMembers are added as admins.

Links to Tickets or other pull requests

BC-8572
hpi-schul-cloud/nuxt-client#3478

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

@hoeppner-dataport hoeppner-dataport changed the title room members are always added as admins BC-8572 - room members are always added as admins Dec 16, 2024
@Metauriel Metauriel merged commit b9b08d0 into main Dec 16, 2024
135 checks passed
@Metauriel Metauriel deleted the BC-8572-room-admin-as-default-role branch December 16, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants