BC-8519 - add room owner role #5393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Metauriel
approved these changes
Dec 13, 2024
uidp
reviewed
Dec 13, 2024
apps/server/src/modules/room-membership/service/room-membership.service.ts
Show resolved
Hide resolved
|
Loki-Afro
pushed a commit
that referenced
this pull request
Dec 16, 2024
* add roomadmin and roomowner roles * remove room_delete permission from roomeditor * creating room memberships is now an operation seperate from adding users. ** creating a room memberships adds a user as owner ** adding a user fails if no membership exists yet * fix room membership rule to use room role to check permissions * ensure that room owners can not be removed from a room --------- Co-authored-by: Thomas Feldtkeller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding new roles for room-owner and room-admins and adapting the permissions and permission-checks accordingly.
Links to Tickets or other pull requests
BC-8519
hpi-schul-cloud/nuxt-client#3473
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.