EW-1070 creating post endpoints to create a course #5385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Fshmit
reviewed
Dec 16, 2024
Fshmit
reviewed
Dec 16, 2024
apps/server/src/modules/common-cartridge/service/common-cartridge-import.service.ts
Outdated
Show resolved
Hide resolved
Fshmit
reviewed
Dec 16, 2024
apps/server/src/modules/common-cartridge/controller/dto/common-cartridge-import-body.params.ts
Outdated
Show resolved
Hide resolved
…dge-import.service.ts Co-authored-by: Fshmit <[email protected]>
Fshmit
requested changes
Dec 19, 2024
...server/src/modules/common-cartridge/controller/utils/common-cartridge-file-validator.pipe.ts
Show resolved
Hide resolved
HKayed
reviewed
Dec 19, 2024
|
|
||
| courseCommonCartridgeMetadata: CourseCommonCartridgeMetadataDto; | ||
| public courseCommonCartridgeMetadata: CourseCommonCartridgeMetadataResponse; |
There was a problem hiding this comment.
If they are not static, why did you change them to public? If they are to be directly read, may I suggest declaring it readonly
There was a problem hiding this comment.
In JavaScript/Typescript, the default is 'public'. I just made it explicit.
HKayed
reviewed
Dec 19, 2024
| export * from './course.query.params'; | ||
| export * from './course.url.params'; | ||
| export { CreateCourseBodyParams } from './create-course-body.params'; |
There was a problem hiding this comment.
I'd say use the barrel export in order to have the whole file follow the same export convention
HKayed
reviewed
Dec 19, 2024
apps/server/src/modules/learnroom/service/common-cartridge-import.service.ts
Show resolved
Hide resolved
HKayed
reviewed
Dec 20, 2024
apps/server/src/modules/common-cartridge/service/common-cartridge-import.service.ts
Show resolved
Hide resolved
|
Fshmit
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates a POST endpoint for courses to create new courses on the API v3 route (NestJS). The
course-clientmodule was renamed tocourses-clientand was moved to theinfrafolder. The NPM scriptgenerate-client:courses-apiwas created to simplify the generation of the client from an Open API specification.Links to Tickets or other pull requests
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.