Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EW-1057: Barrel Exports changes and Deep imports modified #5365

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

HKayed
Copy link
Contributor

@HKayed HKayed commented Nov 29, 2024

Description

In the Dataport TSP code review, the TSP related code were reviewed. In this ticket the TODOs related to imports and barrel files have to be solved. The to-dos include the following:

Explicit export in barrel files (no '*' exports)
No deep module imports if possible (maybe export necassary things from modules - if you are unsure, ask Thomas or Cedric)
Delete 'src' from module imports if it is possible

Changes are done in this scope

TSP (so ungefähr):
infra/tsp-client
infra/sync
modules/provisioning/strategy/tsp

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/secure/RapidBoard.jspa?rapidView=418&projectKey=EW&view=detail&selectedIssue=EW-1057#

Changes

  • Barrel Exports removed
  • Modified module deep imports

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@HKayed HKayed self-assigned this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants