-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EW-1057: Barrel Exports changes and Deep imports modified #5365
Open
HKayed
wants to merge
26
commits into
main
Choose a base branch
from
EW-1057
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixing room date validation on create and update
Quality Gate passedIssues Measures |
…d the parent config added and modified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the Dataport TSP code review, the TSP related code were reviewed. In this ticket the TODOs related to imports and barrel files have to be solved. The to-dos include the following:
Explicit export in barrel files (no '*' exports)
No deep module imports if possible (maybe export necassary things from modules - if you are unsure, ask Thomas or Cedric)
Delete 'src' from module imports if it is possible
Changes are done in this scope
TSP (so ungefähr):
infra/tsp-client
infra/sync
modules/provisioning/strategy/tsp
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/secure/RapidBoard.jspa?rapidView=418&projectKey=EW&view=detail&selectedIssue=EW-1057#
Changes
Approval for review
generate-client:server
was executed in vue frontend and changes were tested and put in a PR with the same branch name.