BC-8460 - Solve circular imports in board collaboration module #5359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bischofmax
changed the title
bergatco
approved these changes
Nov 27, 2024
CeEv
reviewed
Nov 27, 2024
| import { LoggerModule } from '@src/core/logger'; | ||
| import { RoomMemberModule } from '../room-member'; |
There was a problem hiding this comment.
Der Import verlässt das Module und muss mit @modules/room-member geschrieben werden.
CeEv
reviewed
Nov 27, 2024
| import { createConfigModuleOptions, DB_PASSWORD, DB_URL, DB_USERNAME } from '@src/config'; | ||
| import { CoreModule } from '@src/core'; | ||
| import { RabbitMQWrapperModule } from '@src/infra/rabbitmq'; | ||
| import { defaultMikroOrmOptions } from '@shared/common'; | ||
| import { AuthenticationApiModule } from '../authentication/authentication-api.module'; |
CeEv
reviewed
Nov 27, 2024
| import { AuthorizationModule } from '../authorization'; | ||
| import { serverConfig } from '../server'; |
There was a problem hiding this comment.
@ modules ...aber kann im Kontext des TestHelper umbau auch raus.
CeEv
reviewed
Nov 27, 2024
| imports: [ | ||
| ...imports, | ||
| ConfigModule.forRoot(createConfigModuleOptions(testConfig)), | ||
| AuthenticationApiModule, |
There was a problem hiding this comment.
Muss mit TestHelper Umbau wieder raus.
|
CeEv
reviewed
Nov 27, 2024
| import { roomMemberFactory } from '@src/modules/room-member/testing'; | ||
| import { columnFactory, columnBoardFactory } from '../../testing'; | ||
| import { roomFactory } from '@src/modules/room/testing'; |
CeEv
reviewed
Nov 27, 2024
| @@ -12,8 +12,8 @@ import { ToolConfigurationStatusService } from './service/tool-configuration-sta | |||
|
|
|||
| @Module({ | |||
| imports: [ | |||
| forwardRef(() => CommonToolModule), | |||
| forwardRef(() => ExternalToolModule), | |||
| CommonToolModule, | |||
There was a problem hiding this comment.
Uiii ich hoffe das geht gut. :D
CeEv
approved these changes
Nov 27, 2024
wolfganggreschus
pushed a commit
that referenced
this pull request
Nov 27, 2024
Co-authored-by: Cedric Evers <[email protected]> Co-authored-by: hoeppner.dataport <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other pull requests
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.