Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup ancient and false information #5357

Merged
merged 5 commits into from
Dec 2, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions .codacy.yml

This file was deleted.

43 changes: 3 additions & 40 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
# Description
<!--
This is a template to add as many information as possible to the pull request, to help reviewer and as a checklist for you. Points to remember are set in the comments, please read and keep them in mind:
This is a template to add as much information as possible to the pull request, to help reviewer and as a checklist for you. Points to remember are set in the comments, please read and keep them in mind:

- Code should be self-explanatory and share your knowledge with others
- Document code that is not self-explanatory
- Think about bugs and keep security in mind
- Write tests (Unit and Integration), also for error cases
- Main logic should hidden behind the api, never trust the client
- Visible changes should be discussed with the UX-Team from the begining of development; they also have to accept them at the end
- Keep the changelog up-to-date
- Main logic should be hidden behind the api, never trust the client
- Visible changes should be discussed with the UX-Team from the beginning of development; they also have to accept them at the end
- Leave the code cleaner than you found it. Remove unnecessary lines. Listen to the linter.
-->

Expand All @@ -19,45 +18,9 @@ Base links to copy
- https://ticketsystem.dbildungscloud.de/browse/BC-????
-->

## Changes
<!--
What will the PR change?
Why are the changes required?
Short notice if a ticket exists, more detailed if not
-->

## Datasecurity
<!--
Notice about:
- model changes
- logging of user data
- right changes
- and other user data stuff
If you are not sure if it is relevant, take a look at confluence or ask the data-security team.
-->

## Deployment
<!--
Keep in mind to changes to seed data, if changes are done by migration scripts.
Changes to the infrastructure have to be discussed with the devops

This point should includes following information:
- What is required for deployment?
- Environment variables like FEATURE_XY=true
- Migration scripts to run, other requirements
-->

## New Repos, NPM pakages or vendor scripts
<!--
Keep in mind the stability, performance, activity and author.

Describe why it is needed.
-->

## Approval for review

- [ ] DEV: If api was changed - `generate-client:server` was executed in vue frontend and changes were tested and put in a PR with the same branch name.
- [ ] QA: In addition to review, the code has been manually tested (if manual testing is possible)
- [ ] All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

> Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.
1 change: 0 additions & 1 deletion .github/autolabeler.yml

This file was deleted.

9 changes: 0 additions & 9 deletions SECURITY.md

This file was deleted.

Loading