Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N21-2287 Fix partial course sync start for admins #5343

Merged
merged 6 commits into from
Nov 15, 2024

Conversation

MarvinOehlerkingCap
Copy link
Contributor

@MarvinOehlerkingCap MarvinOehlerkingCap commented Nov 14, 2024

Description

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

Copy link
Contributor

@GordonNicholasCap GordonNicholasCap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, small changes needed

apps/server/src/modules/group/domain/group.spec.ts Outdated Show resolved Hide resolved
apps/server/src/modules/learnroom/domain/do/course.ts Outdated Show resolved Hide resolved
@MarvinOehlerkingCap MarvinOehlerkingCap merged commit 9c8ba28 into main Nov 15, 2024
76 checks passed
@MarvinOehlerkingCap MarvinOehlerkingCap deleted the N21-2287-fix-partial-sync branch November 15, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants