Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-8362 - RoomMember groups are shown in class administration and during sync of courses with groups #5333

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

MartinSchuhmacher
Copy link
Contributor

@MartinSchuhmacher MartinSchuhmacher commented Nov 8, 2024

Description

This filter (filtering out type 'room') needs to be done for:

  • class/group overview in administration for NBC (vue client)
  • synchronizing courses with groups (used with 'availableGroupsForCourseSync', extend scope here)

Links to Tickets or other pull requests

BC-8362

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@MartinSchuhmacher MartinSchuhmacher self-assigned this Nov 8, 2024
Copy link

@MartinSchuhmacher MartinSchuhmacher merged commit d1547f4 into main Nov 11, 2024
77 checks passed
@MartinSchuhmacher MartinSchuhmacher deleted the BC-8362-part-two branch November 11, 2024 06:42
hoeppner-dataport pushed a commit that referenced this pull request Nov 18, 2024
…ing sync of courses with groups (#5333)

* allow more group types in filtering for class groups

* specifying which groups can be chosen for course synch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants