Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-5724 improve logging #5183

Merged
merged 7 commits into from
Aug 20, 2024
Merged

BC-5724 improve logging #5183

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
19f5bfc
BC-5724 improve logging
Loki-Afro Aug 15, 2024
21a67d7
Merge branch 'main' into bc-5724
Loki-Afro Aug 19, 2024
01c5ca8
fixed test
Loki-Afro Aug 19, 2024
a3424ce
linting
Loki-Afro Aug 20, 2024
0130850
seriously?
Loki-Afro Aug 20, 2024
c4050c3
yes
Loki-Afro Aug 20, 2024
1697b04
wtf
Loki-Afro Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/server/src/core/error/loggable/axios-error.loggable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

getLogMessage(): LogMessage | ErrorLogMessage | ValidationErrorLogMessage {
return {
message: this.axiosError.message,
message: `message: ${this.axiosError.message} code: ${this.axiosError.code}`,

Check failure on line 14 in apps/server/src/core/error/loggable/axios-error.loggable.ts

View workflow job for this annotation

GitHub Actions / nest_lint 

Invalid type "string | undefined" of template literal expression
Loki-Afro marked this conversation as resolved.
Show resolved Hide resolved
type: this.type,
data: JSON.stringify(this.axiosError.response?.data),
stack: this.axiosError.stack,
Expand Down
4 changes: 2 additions & 2 deletions apps/server/src/modules/tool/external-tool/service/external-tool.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ export class ExternalToolService {
try {
await this.addExternalOauth2DataToConfig(tool.config);
} catch (e) {
this.legacyLogger.debug(
`Could not resolve oauth2Config of tool with clientId ${tool.config.clientId}. It will be filtered out.`
this.legacyLogger.warn(
`Could not resolve oauth2Config of tool with clientId ${tool.config.clientId} and name ${tool.name}. It will be filtered out.`
);
return undefined;
}
Expand Down
Loading