Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-7822 - Implement new sidebar option for rooms #5177

Merged
merged 7 commits into from
Aug 22, 2024
Merged

Conversation

MartinSchuhmacher
Copy link
Contributor

@MartinSchuhmacher MartinSchuhmacher commented Aug 12, 2024

Description

As a teacher, I want to see a new sidebar option for rooms as a new beta option.

Links to Tickets or other pull requests

BC-7822

hpi-schul-cloud/dof_app_deploy#934
hpi-schul-cloud/nuxt-client#3355
hpi-schul-cloud/schulcloud-client#3500

Screenshots of UI changes

grafik

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@MartinSchuhmacher MartinSchuhmacher marked this pull request as ready for review August 20, 2024 12:30
"FEATURE_ROOMS_ENABLED": {
"type": "boolean",
"default": "false",
"description": "Enables the rooms feature"
}
},
"required": []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want this to be enabled on local and old e2e, then you can add to true on development.json and test.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh! good point! not sure about the e2e currently, but on local would be nice

Copy link

@MartinSchuhmacher MartinSchuhmacher merged commit 7c42c84 into main Aug 22, 2024
81 checks passed
@MartinSchuhmacher MartinSchuhmacher deleted the BC-7822-rooms branch August 22, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants