Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-2075: sync existing course #5165

Merged
merged 90 commits into from
Sep 3, 2024
Merged

N21-2075: sync existing course #5165

merged 90 commits into from
Sep 3, 2024

Conversation

sdinkov
Copy link
Contributor

@sdinkov sdinkov commented Aug 2, 2024 •
edited by IgorCapCoder
Loading

Description

Synchronize exisiting course

  • add api endpoint to start course synchronization

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

sdinkov and others added 30 commits August 2, 2024 10:51
@sdinkov
add sync existing course
11002da
@sdinkov
update imports; cleanup
b51c574
@sdinkov
Merge branch 'main' into N21-2111-sync-existing-course
f39758c
@mrikallab
N21-2075 modify course metadata
1858e47
@sdinkov
update tests course entity mapping
d6c84a1
@sdinkov
Merge branch 'main' into N21-2075-sync-existing-course
a3fc953
@mrikallab
N21-2075 feature flag
5baad42
@mrikallab
Merge remote-tracking branch 'origin/N21-2075-sync-existing-course' i…
7d0d197 
…nto N21-2075-sync-existing-course
@sdinkov
Merge branch 'main' into N21-2075-sync-existing-course
914a4b3
@mrikallab
N21-2075 CLEAN UP
5c9f559
@mrikallab
N21-2075 CLEAN UP
be04430
@mrikallab
N21-2075 CLEAN UP
97b1ad3
@mrikallab
Merge remote-tracking branch 'origin/N21-2075-sync-existing-course' i…
eea41b5 
…nto N21-2075-sync-existing-course
@mrikallab
N21-2075 WIP endpoint
b122a30
@mrikallab
N21-2075 WIP mapper
591130f
@mrikallab
N21-2075 WIP
4d11d79
@sdinkov
update courses /all endpoint
37b05f4
@mrikallab
N21-2075 WIP + Clean up
cab5fdd
@mrikallab
N21-2075 change to classNames
02d9a39
@mrikallab
N21-2075 fix teacherName
a18e3a1
@sdinkov
update get course infos
2a19706
@sdinkov
update course DO
1527469
@mrikallab
N21-2075 fix classNames
d316d7f
@mrikallab
Merge remote-tracking branch 'origin/N21-2075-sync-existing-course' i…
38f9bbb 
…nto N21-2075-sync-existing-course
@mrikallab
N21-2075 permission check
19f6860
@sdinkov
update course synchronization
51d8801
@mrikallab
N21-2075 fix permission check
cbf29e3
@sdinkov
update course sync start
05743f2
@mrikallab
N21-2075 fix untilDate
44be93e
@sdinkov
add migration + cleanup
27cd924
MarvinOehlerkingCap
MarvinOehlerkingCap previously requested changes Aug 29, 2024
View reviewed changes
apps/server/src/modules/authorization/domain/rules/course.rule.ts Show resolved Hide resolved
apps/server/src/modules/class/repo/classes.repo.spec.ts Outdated Show resolved Hide resolved
apps/server/src/modules/learnroom/controller/api-test/course-info.api.spec.ts Outdated Show resolved Hide resolved
apps/server/src/modules/learnroom/controller/course.controller.ts Outdated Show resolved Hide resolved
apps/server/src/modules/learnroom/controller/dto/request/course-filter-params.ts Outdated Show resolved Hide resolved
apps/server/src/modules/learnroom/learnroom.module.ts Outdated Show resolved Hide resolved
apps/server/src/modules/learnroom/uc/course-info.uc.ts Outdated Show resolved Hide resolved
apps/server/src/modules/learnroom/uc/course-info.uc.ts Outdated Show resolved Hide resolved
apps/server/src/modules/learnroom/uc/dto/course-info.dto.ts Outdated Show resolved Hide resolved
apps/server/src/shared/repo/course/course.repo.ts Outdated Show resolved Hide resolved
sdinkov and others added 14 commits August 30, 2024 14:52
@sdinkov
update review changes
17a3a07
@sdinkov
Merge branch 'main' into N21-2075-sync-existing-course
14126ae
@sdinkov
correct typo
41da6f3
@sdinkov
update course info uc
bc7f721
@mrikallab
Merge branch 'refs/heads/main' into N21-2075-sync-existing-course
640e299
@mrikallab
Merge remote-tracking branch 'origin/N21-2075-sync-existing-course' i…
36ac93b 
…nto N21-2075-sync-existing-course
@mrikallab
Merge branch 'main' into N21-2075-sync-existing-course
8971d32
@mrikallab
N21-2075 extend delete course
ef03b5e
@sdinkov
update course-info
37a9575
@mrikallab
N21-2075 extend delete course
d371047
@mrikallab
Merge remote-tracking branch 'origin/N21-2075-sync-existing-course' i…
2d672d3 
…nto N21-2075-sync-existing-course
@sdinkov
update course info tests
174f0ef
@sdinkov
Merge branch 'N21-2075-sync-existing-course' of https://github.com/hp…
c93ccd7 
…i-schul-cloud/schulcloud-server into N21-2075-sync-existing-course
@mrikallab
Merge branch 'refs/heads/main' into N21-2075-sync-existing-course
77f1d9c
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 3, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@IgorCapCoder IgorCapCoder merged commit 21a5f8e into main Sep 3, 2024
76 checks passed
@IgorCapCoder IgorCapCoder deleted the N21-2075-sync-existing-course branch September 3, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgorCapCoder IgorCapCoder IgorCapCoder approved these changes

@MarvinOehlerkingCap MarvinOehlerkingCap MarvinOehlerkingCap left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sdinkov @IgorCapCoder @MarvinOehlerkingCap @mrikallab