BC-6459 Replace passing error handling in tldraw #5053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CeEv
commented
Jun 6, 2024
apps/server/src/modules/tldraw/service/tldraw.ws.service.spec.ts
Outdated
Show resolved
Hide resolved
…m/hpi-schul-cloud/schulcloud-server into BC-6459-pass-tldraw-error-to-pipe
bischofmax
reviewed
Jun 7, 2024
apps/server/src/modules/tldraw/controller/api-test/tldraw.ws.api.spec.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/tldraw/service/tldraw.ws.service.spec.ts
Outdated
Show resolved
Hide resolved
bischofmax
reviewed
Jun 7, 2024
apps/server/src/modules/tldraw/controller/api-test/tldraw.ws.api.spec.ts
Show resolved
Hide resolved
bischofmax
reviewed
Jun 7, 2024
bischofmax
reviewed
Jun 7, 2024
| @@ -479,13 +482,10 @@ describe('TldrawWSService', () => { | |||
| it('should send to every client', async () => { | |||
| const { messageHandlerSpy, sendSpy, getYDocSpy, closeConnSpy } = await setup(); | |||
|
|
|||
| await service.setupWsConnection(ws, 'TEST'); | |||
| await delay(20); | |||
| await expect(service.setupWsConnection(ws, 'TEST')).resolves.toBeUndefined(); | |||
There was a problem hiding this comment.
Ah interessant. @bergatco Über diesen Fall hatten wir gerade an anderer Stelle gesprochen.
bischofmax
reviewed
Jun 7, 2024
apps/server/src/modules/tldraw/service/tldraw.ws.service.spec.ts
Outdated
Show resolved
Hide resolved
bischofmax
approved these changes
Jun 10, 2024
bischofmax
approved these changes
Jun 11, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other pull requests
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.