Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-6453 - Add authorization service client module #5050

Merged
merged 47 commits into from
Jun 13, 2024
Merged

BC-6453 - Add authorization service client module #5050

merged 47 commits into from
Jun 13, 2024

Conversation

bergatco
Copy link
Contributor

@bergatco bergatco commented Jun 5, 2024 •
edited
Loading

Description

Add authorization client module based on authorization api.

Links to Tickets or other pull requests

JIRA : https://ticketsystem.dbildungscloud.de/browse/BC-6453

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@bergatco bergatco added the WIP This feature branch is in progress, do not merge into master. label Jun 5, 2024
@bergatco bergatco self-assigned this Jun 5, 2024
bergatco and others added 9 commits June 5, 2024 12:59
bergatco and others added 9 commits June 7, 2024 13:29
@bergatco
Copy link
Contributor Author

@bischofmax I have changed the structure of authorization-client.adapter.spec.ts to be somewhat similar to etherpad-client.adapter.spec.ts. Meaning having separated setup` functions for each scenario as well as introducing some more "sub scenarios".

Many thanks for your feedback!!!

@bergatco bergatco requested a review from bischofmax June 12, 2024 08:26
@bergatco
BC-6453 - rename functions
eacdd8b 
- `checkPermissionByReferences` to `checkPermissionsByReference`
- `hasPermissionByReferences` to `hasPermissionsByReference`
@bergatco bergatco removed the WIP This feature branch is in progress, do not merge into master. label Jun 12, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@bergatco bergatco merged commit 28a998e into main Jun 13, 2024
54 of 56 checks passed
@bergatco bergatco deleted the BC-6453-add-authorisation-service-client-module branch June 13, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CeEv CeEv CeEv approved these changes

@bischofmax bischofmax bischofmax approved these changes

@dyedwiper dyedwiper Awaiting requested review from dyedwiper

@KalliSfak KalliSfak Awaiting requested review from KalliSfak

@SevenWaysDP SevenWaysDP Awaiting requested review from SevenWaysDP

Assignees

@bergatco bergatco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bergatco @CeEv @SevenWaysDP @bischofmax