N21-1968 schulconnex config fix #5002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loki-Afro
approved these changes
May 14, 2024
| const payload: ClientCredentialsGrantTokenRequest = new ClientCredentialsGrantTokenRequest({ | ||
| client_id: clientId, | ||
| client_secret: clientSecret, | ||
| client_id: clientId ?? '', |
There was a problem hiding this comment.
checkOptions above makes sure this is set, but ok...
There was a problem hiding this comment.
Yes, but the ide complains... i am not happy about those checks everywhere. So i created a ticket to refactor it :)
virgilchiriac
approved these changes
May 14, 2024
|
virgilchiriac
pushed a commit
that referenced
this pull request
May 14, 2024
* changes schulconnex configs from config service and log message if their are missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes schulconnex module to registerAsync for getting configuration from configservice.
Log message if config is missing.
Links to Tickets or other pull requests
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.