Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-7162 Include within the imported course results that whiteboard content is not incorporated in the import. #4983

Merged
merged 6 commits into from
May 13, 2024

Conversation

blazejpass
Copy link
Contributor

@blazejpass blazejpass commented May 6, 2024

Description

Information about not fully copying drawing node element is not provided, so we changed status it recursive copy visitor. Also we found that the statuses of board were derived only from first line of descendants and full path/tree of descendants are omitted (recursive change is proposed).

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-7162

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@blazejpass blazejpass added the WIP This feature branch is in progress, do not merge into master. label May 6, 2024
@blazejpass blazejpass self-assigned this May 6, 2024
@blazejpass blazejpass changed the title initial testing of recursive deriving of statuses BC-7162 Include within the imported course results that whiteboard content is not incorporated in the import. May 7, 2024
blazejpass added 3 commits May 8, 2024 12:33
# Conflicts:
#	apps/server/src/modules/copy-helper/service/copy-helper.service.spec.ts
#	apps/server/src/modules/copy-helper/service/copy-helper.service.ts
@blazejpass blazejpass added waiting for review and removed WIP This feature branch is in progress, do not merge into master. labels May 9, 2024
Copy link

@blazejpass blazejpass merged commit 4087a28 into main May 13, 2024
54 of 56 checks passed
@blazejpass blazejpass deleted the BC-7162-course-import-include-whiteboard branch May 13, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants