N21-1887 Rollback user from a user login migration #4978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
3 tasks
arnegns
suggested changes
May 2, 2024
...rver/src/modules/user-login-migration/controller/user-login-migration-rollback.controller.ts
Outdated
Show resolved
Hide resolved
...rver/src/modules/user-login-migration/controller/user-login-migration-rollback.controller.ts
Show resolved
Hide resolved
...erver/src/modules/user-login-migration/service/user-login-migration-rollback.service.spec.ts
Show resolved
Hide resolved
| throw new UserLoginMigrationNotFoundLoggableException(user.schoolId); | ||
| } | ||
|
|
||
| if (!user.lastLoginSystemChange) { |
There was a problem hiding this comment.
Maybe we should create a function at the user object which wraps the prop.
Something like isUserMigrated().. to have more "logic" at the domain object
There was a problem hiding this comment.
I agree, but the UserDO is not one of the new DOs and would have to be refactored in order to work with functions. This should be a separate refactoring, since it can break in a lot of places.
apps/server/src/modules/user-login-migration/uc/user-login-migration-rollback.uc.spec.ts
Outdated
Show resolved
Hide resolved
arnegns
approved these changes
May 2, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other pull requests
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.