Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-4048 Remove unused PermissionService #4977

Merged
merged 2 commits into from
May 6, 2024
Merged

BC-4048 Remove unused PermissionService #4977

merged 2 commits into from
May 6, 2024

Conversation

dyedwiper
Copy link
Contributor

@dyedwiper dyedwiper commented May 2, 2024 •
edited
Loading

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-4048

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@dyedwiper dyedwiper enabled auto-merge (squash) May 6, 2024 07:25
@dyedwiper dyedwiper disabled auto-merge May 6, 2024 07:25
@dyedwiper dyedwiper enabled auto-merge (squash) May 6, 2024 07:28
@dyedwiper dyedwiper disabled auto-merge May 6, 2024 07:59
@dyedwiper dyedwiper enabled auto-merge (squash) May 6, 2024 07:59
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dyedwiper dyedwiper merged commit ff25454 into main May 6, 2024
55 of 56 checks passed
@dyedwiper dyedwiper deleted the BC-4048-remove-permission-service branch May 6, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SevenWaysDP SevenWaysDP SevenWaysDP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dyedwiper @SevenWaysDP