Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-7167 - add missing ConfigMap and concurrencyPolicy #4959

Merged
merged 5 commits into from
Apr 25, 2024

Conversation

bn-pass
Copy link
Contributor

@bn-pass bn-pass commented Apr 24, 2024

Description

This PR adds some elements for both of the moin.schule integration CronJobs.

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-7167

Changes

  • added dedicated ConfigMap for the moin-schule-users-deletion-queueing-cronjob
  • added concurrencyPolicy (set to Forbid) and EXIT_ON_ERROR env var (set to true) to both of the moin.schule integration CronJobs

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

Copy link
Member

@Loki-Afro Loki-Afro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EXIT_ON_ERROR is not set to true

@bn-pass bn-pass requested a review from Loki-Afro April 25, 2024 11:33
@bn-pass
Copy link
Contributor Author

bn-pass commented Apr 25, 2024

EXIT_ON_ERROR is not set to true

Thanks, added to both of these moin.schule integration CronJobs.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bn-pass bn-pass merged commit 321f98b into main Apr 25, 2024
55 of 56 checks passed
@bn-pass bn-pass deleted the BC-7167-add-missing-configmap branch April 25, 2024 13:05
bergatco pushed a commit that referenced this pull request May 6, 2024
* add dedicated ConfigMap for the moin.schule users deletion queueing CronJob

* add concurrencyPolicy: Forbid to the moin.schule integration CronJobs

* add EXIT_ON_ERROR: "true" to both of the moin.schule integration CronJobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants