-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC-7167 - add missing ConfigMap and concurrencyPolicy #4959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WojciechGrancow
approved these changes
Apr 25, 2024
Loki-Afro
requested changes
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EXIT_ON_ERROR is not set to true
Thanks, added to both of these moin.schule integration CronJobs. |
Quality Gate passedIssues Measures |
Loki-Afro
approved these changes
Apr 25, 2024
bergatco
pushed a commit
that referenced
this pull request
May 6, 2024
* add dedicated ConfigMap for the moin.schule users deletion queueing CronJob * add concurrencyPolicy: Forbid to the moin.schule integration CronJobs * add EXIT_ON_ERROR: "true" to both of the moin.schule integration CronJobs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds some elements for both of the moin.schule integration CronJobs.
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/browse/BC-7167
Changes
moin-schule-users-deletion-queueing-cronjob
concurrencyPolicy
(set toForbid
) andEXIT_ON_ERROR
env var (set totrue
) to both of the moin.schule integration CronJobsApproval for review
generate-client:server
was executed in vue frontend and changes were tested and put in a PR with the same branch name.