-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC-7185 - fix unexpected EXIT_ON_ERROR values #4949
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change it to EXIT_ON_ERROR: "true" on all 3 cases
you are only using new code here, e.g. non-feathers code, code that has to be run fine. if it doesn't fix the underlying issue
Quality Gate passedIssues Measures |
* set EXIT_ON_ERROR to false for main API ConfigMap * revert EXIT_ON_ERROR in api's ConfigMap as it doesn't work * change the EXIT_ON_ERROR env var value back to true (as false is default back again) * explicitly set EXIT_ON_ERROR to false for the Admin API deployment's ConfigMap * change EXIT_ON_ERROR to true
* set EXIT_ON_ERROR to false for main API ConfigMap * revert EXIT_ON_ERROR in api's ConfigMap as it doesn't work * change the EXIT_ON_ERROR env var value back to true (as false is default back again) * explicitly set EXIT_ON_ERROR to false for the Admin API deployment's ConfigMap * change EXIT_ON_ERROR to true
Description
Links to Tickets or other pull requests
ticket: https://ticketsystem.dbildungscloud.de/browse/BC-7185
other PR: hpi-schul-cloud/dof_app_deploy#851
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:server
was executed in vue frontend and changes were tested and put in a PR with the same branch name.